-
Notifications
You must be signed in to change notification settings - Fork 937
VsCode Tasks PR1 : Introducing default build property with create project quickpics #26315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you changing the APIs and this might have breaking changes. please test the extension in vscode as well as in ADS.
Yes, I have already tested the end-to-end functionality in ADS and vsCode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances project creation in the Data Workspace extension by adding support for configuring a default build task when creating a new SQL project.
- Updated the IWorkspaceService interface and project provider implementations to accept a new configureDefaultBuild parameter.
- Enhanced the UI flows (NewProjectDialog and QuickPick) to prompt the user for default build configuration.
- Added new localization strings and unit tests to validate the behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
extensions/data-workspace/src/test/workspaceService.test.ts | Added a unit test to verify createProject correctly passes the new parameter. |
extensions/data-workspace/src/services/workspaceService.ts | Updated createProject to accept and forward the configureDefaultBuild parameter. |
extensions/data-workspace/src/dialogs/newProjectQuickpick.ts | Modified project creation flow to prompt and handle default build configuration. |
extensions/data-workspace/src/dialogs/newProjectDialog.ts | Passed the dialog model’s new default build flag to the createProject method. |
extensions/data-workspace/src/common/interfaces.ts | Updated the project creation interface to include the new parameter. |
extensions/data-workspace/src/common/constants.ts | Added localization strings for the Yes/No options and confirmation message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces default build configuration support during new project creation in the Data Workspace extension.
- Adds a new parameter, configureDefaultBuild, to the createProject API across interfaces, implementations, and dialogs.
- Enhances UI flows to prompt users for default build configuration and updates unit tests to verify the new behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
extensions/data-workspace/src/test/workspaceService.test.ts | Added unit test validating the new configureDefaultBuild parameter from quickpick selections. |
extensions/data-workspace/src/services/workspaceService.ts | Updated createProject method to accept and propagate the configureDefaultBuild parameter. |
extensions/data-workspace/src/dialogs/newProjectQuickpick.ts | Modified the quickpick flow to prompt the user for the default build configuration setting. |
extensions/data-workspace/src/dialogs/newProjectDialog.ts | Updated project creation call to pass the new configureDefaultBuild property from the dialog model. |
extensions/data-workspace/src/common/interfaces.ts | Updated createProject interface to include the new parameter and its documentation. |
extensions/data-workspace/src/common/constants.ts | Added new localized strings for the yes/no quickpick and confirmation dialog related to default build configuration. |
This pull request introduces support for configuring a default build task when creating new projects in the Data Workspace extension. The changes include updates to the
createProject
method to accept a new parameter, UI enhancements to prompt users for this configuration, and corresponding updates to the test suite.Enhancements to project creation:
Added a new parameter,
configureDefaultBuild
, to thecreateProject
method in theIWorkspaceService
interface and its implementations. This parameter determines whether the default build configuration should be set for a new project. (extensions/data-workspace/src/common/interfaces.ts
[1]extensions/data-workspace/src/services/workspaceService.ts
[2]Updated the
NewProjectDialogModel
class to include aconfigureDefaultBuild
property, defaulting tofalse
. This ensures the dialog model can store the user's choice for configuring the default build. (extensions/data-workspace/src/dialogs/newProjectDialog.ts
extensions/data-workspace/src/dialogs/newProjectDialog.tsR27)Modified the
NewProjectDialog
andcreateNewProjectWithQuickpick
flows to prompt the user with a Yes/No dialog for configuring the default build task. The user's choice is passed to thecreateProject
method. (extensions/data-workspace/src/dialogs/newProjectDialog.ts
[1]extensions/data-workspace/src/dialogs/newProjectQuickpick.ts
[2]Localization updates:
extensions/data-workspace/src/common/constants.ts
[1] [2]Test coverage:
createProject
method correctly passes all parameters, includingconfigureDefaultBuild
, to the underlying implementation. (extensions/data-workspace/src/test/workspaceService.test.ts
extensions/data-workspace/src/test/workspaceService.test.tsR326-R359)# Pull Request Template – Azure Data StudioDescription
This PR adds the ability provide a quickpick option to the user to select whether they want to have a default build configuration during the creation of the new sql project as shown in below image

Code Changes Checklist
npm run test
)Reviewers: Please read our reviewer guidelines