Fixing the missing option from vscode "create project from database" #26317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssreerama
commented
May 26, 2025
|
Is there a way to add a test for this launch point? |
Yeah, having a test that checks the option would be helpful to catch any such regression in future, will add a test for that! |
llali
approved these changes
May 29, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the 'create project from database' option was not visible in VS Code by updating the "when" condition for the command in package.json.
- Updated the regex in the "when" condition to match the new viewItem syntax.
- Simplified the viewItem constraint to support the correct visibility.
Comments suppressed due to low confidence (1)
extensions/sql-database-projects/package.json:480
- Consider adding an inline comment explaining the rationale behind the updated regex pattern for clarity and future maintenance.
"when": "!azdataAvailable && view == objectExplorer && viewItem =~ /\btype=(disconnectedServer|Server|Database)\b/",
chlafreniere
approved these changes
Jun 2, 2025
Benjin
approved these changes
Jun 3, 2025
zijchen
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template – Azure Data Studio
This pull request includes a small change to the
extensions/sql-database-projects/package.jsonfile. The change simplifies thewhencondition for thesqlDatabaseProjects.createProjectFromDatabasecommand by updating specificviewItemconstraints.Description
'Create project from database' option is not visible to the users in vscode with one of the recent releases. This PR fixes the issue by updating the
viewItemconstraint from thewhencondition for thesqlDatabaseProjects.createProjectFromDatabasecommand in thepackage.jsonfile that is stopping the option being visible, as viewItem current syntax is not supported.Issue: #26309
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines
Before: VsCode
After: VsCode
