Fixing custom search parameter bugs. #5024

v-isyamauchi-gh · 2025-06-17T17:03:05Z

Description

The change addresses issues mentioned in the bug below that are related to customer search parameters.

Related issues

Addresses [issue #117004].

Bug 117004: Custom SearchParameter with same Code Affecting Built-In Search Functionality in FHIR Service

Testing

Tested manually with a local server and also by adding UTs and E2E tests.

FHIR Team Checklist

Update the title of the PR to be succinct and less than 65 characters
Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
CI is green before merge
Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

v-isyamauchi-gh · 2025-06-17T17:14:35Z

@v-isyamauchi-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

v-isyamauchi-gh · 2025-06-17T17:14:50Z

@v-isyamauchi-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

v-isyamauchi-gh · 2025-06-17T17:15:16Z

@v-isyamauchi-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

v-isyamauchi-gh · 2025-06-17T17:15:31Z

@v-isyamauchi-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

v-isyamauchi-gh · 2025-06-17T17:15:48Z

@v-isyamauchi-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

v-isyamauchi-gh · 2025-06-17T17:16:05Z

@v-isyamauchi-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

src/Microsoft.Health.Fhir.Core/Features/Definition/SearchParameterDefinitionBuilder.cs

....Fhir.Shared.Core.UnitTests/Features/Search/SearchParameters/SearchParameterComparerTests.cs

src/Microsoft.Health.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterComparer.cs

v-isyamauchi-gh · 2025-06-18T17:52:41Z

/azp run

azure-pipelines · 2025-06-18T17:52:51Z

Azure Pipelines successfully started running 1 pipeline(s).

v-isyamauchi-gh · 2025-06-18T22:51:35Z

/azp run

azure-pipelines · 2025-06-18T22:51:50Z

Azure Pipelines successfully started running 1 pipeline(s).

v-isyamauchi-gh · 2025-06-19T14:41:15Z

@v-isyamauchi-gh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree company="Microsoft"

src/Microsoft.Health.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterComparer.cs

v-isyamauchi-gh · 2025-06-30T15:50:16Z

/azp run

azure-pipelines · 2025-06-30T15:50:31Z

Azure Pipelines successfully started running 1 pipeline(s).

…ub.com/microsoft/fhir-server into personal/v-isyamauchi/custom-sp-bugfix

v-isyamauchi-gh added 2 commits June 16, 2025 10:07

Fixing custom search parameter bugs.

57aa408

Adding a UT for delete search parameters.

d6c1e40

v-isyamauchi-gh added this to the CY25Q2/2Wk06 milestone Jun 17, 2025

v-isyamauchi-gh added Bug Azure API for FHIR Azure Healthcare APIs Open source labels Jun 17, 2025

v-isyamauchi-gh changed the title ~~Fixing custom search parameter bugs.~~ [Do Not Review] Fixing custom search parameter bugs. Jun 17, 2025

github-advanced-security bot found potential problems Jun 17, 2025

View reviewed changes

v-isyamauchi-gh added 2 commits June 18, 2025 08:35

Merging main.

d82b7e2

Fixing a failed E2E test.

696adda

Fixing R5 test failure.

e52e4ff

Merge branch 'main' into personal/v-isyamauchi/custom-sp-bugfix

0f657ad

v-isyamauchi-gh changed the title ~~[Do Not Review] Fixing custom search parameter bugs.~~ Fixing custom search parameter bugs. Jun 24, 2025

v-isyamauchi-gh marked this pull request as ready for review June 24, 2025 17:58

v-isyamauchi-gh requested a review from a team as a code owner June 24, 2025 17:58

Addressing bot's comments

a91d302

github-advanced-security bot found potential problems Jun 24, 2025

View reviewed changes

src/Microsoft.Health.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterComparer.cs Show resolved Hide resolved

src/Microsoft.Health.Fhir.Shared.Core/Features/Search/Parameters/SearchParameterComparer.cs Show resolved Hide resolved

Adding more UTs for SP definition builder.

e0f8220

v-isyamauchi-gh added 4 commits June 26, 2025 08:08

Merge branch 'main' into personal/v-isyamauchi/custom-sp-bugfix

4d00ede

Updating the interface/implementation of the SP comparer.

e96e51d

Merge branch 'main' into personal/v-isyamauchi/custom-sp-bugfix

c1dcb5d

Adding more UTs for SP comparer.

f793eff

v-isyamauchi-gh added 5 commits July 3, 2025 08:11

Merge branch 'main' into personal/v-isyamauchi/custom-sp-bugfix

1029773

Merge branch 'personal/v-isyamauchi/custom-sp-bugfix' of https://gith…

7c5b37c

…ub.com/microsoft/fhir-server into personal/v-isyamauchi/custom-sp-bugfix

Merge branch 'main' into personal/v-isyamauchi/custom-sp-bugfix

6df7d3f

Adding a handling for base resource types.

3df521a

Fixing a merge conflict.

a13f38e

feordin approved these changes Jul 28, 2025

View reviewed changes

Fixing custom search parameter bugs. #5024

Are you sure you want to change the base?

Fixing custom search parameter bugs. #5024

Uh oh!

Conversation

v-isyamauchi-gh commented Jun 17, 2025

Description

Related issues

Testing

FHIR Team Checklist

Semver Change (docs)

Uh oh!

v-isyamauchi-gh commented Jun 17, 2025

Uh oh!

v-isyamauchi-gh commented Jun 17, 2025

Uh oh!

v-isyamauchi-gh commented Jun 17, 2025

Uh oh!

v-isyamauchi-gh commented Jun 17, 2025

Uh oh!

v-isyamauchi-gh commented Jun 17, 2025

Uh oh!

v-isyamauchi-gh commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

v-isyamauchi-gh commented Jun 18, 2025

Uh oh!

azure-pipelines bot commented Jun 18, 2025

Uh oh!

v-isyamauchi-gh commented Jun 18, 2025

Uh oh!

azure-pipelines bot commented Jun 18, 2025

Uh oh!

v-isyamauchi-gh commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

v-isyamauchi-gh commented Jun 30, 2025

Uh oh!

azure-pipelines bot commented Jun 30, 2025

Uh oh!

Uh oh!