Skip to content

Extended Tokens: Input #34796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: extended-tokens
Choose a base branch
from
Open

Conversation

etudie
Copy link

@etudie etudie commented Jul 7, 2025

This pull request introduces updates to the @fluentui/react-input package, focusing on replacing hardcoded tokens with semanticTokens for styling consistency and adding new semantic token definitions. These changes aim to improve maintainability and alignment with design specifications.

Updates to @fluentui/react-input styling:

  • Replaced tokens with semanticTokens in useInputStyles.styles.ts for properties like borderRadius, backgroundColor, borderColor, and color, ensuring a more consistent and semantic approach to styling. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Dependency and token updates:

  • Added @fluentui/semantic-tokens as a dependency in package.json to support the use of semantic tokens.
  • Introduced a new semantic token foregroundCtrlIconOnNeutralRest in semantic-tokens and updated its fallback value to include colorNeutralForeground3. [1] [2] [3]

Changelog:

  • Added a changelog entry for the @fluentui/react-input package to document the minor update and its impact on dependent packages.

@etudie etudie requested review from a team as code owners July 7, 2025 18:42
@tudorpopams tudorpopams requested a review from marcosmoura July 8, 2025 12:02
@Mitch-At-Work
Copy link
Contributor

Looks like we'll need to account for the corner radius similar to textArea here:
image

@Mitch-At-Work
Copy link
Contributor

Looks like both pressed (active) and selected (focus-within) states use the same color for the colored bottom border bar, but they should have alternate states based on original spec, let's review those and ensure that pressed takes priority and has it's legacy color enabled (+ pressed semantic token)

Copy link
Contributor

@Mitch-At-Work Mitch-At-Work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks required on the bottom bar

@etudie
Copy link
Author

etudie commented Jul 14, 2025

image

Updated border

Can you clarify on this? I'll reach out. Thanks! @Mitch-At-Work

Looks like both pressed (active) and selected (focus-within) states use the same color for the colored bottom border bar, but they should have alternate states based on original spec, let's review those and ensure that pressed takes priority and has it's legacy color enabled (+ pressed semantic token)

Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants