-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Extended Tokens: Input #34796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: extended-tokens
Are you sure you want to change the base?
Extended Tokens: Input #34796
Conversation
Looks like both pressed (active) and selected (focus-within) states use the same color for the colored bottom border bar, but they should have alternate states based on original spec, let's review those and ensure that pressed takes priority and has it's legacy color enabled (+ pressed semantic token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor tweaks required on the bottom bar
![]() Updated border Can you clarify on this? I'll reach out. Thanks! @Mitch-At-Work
|
Pull request demo site: URL |
This pull request introduces updates to the
@fluentui/react-input
package, focusing on replacing hardcodedtokens
withsemanticTokens
for styling consistency and adding new semantic token definitions. These changes aim to improve maintainability and alignment with design specifications.Updates to
@fluentui/react-input
styling:tokens
withsemanticTokens
inuseInputStyles.styles.ts
for properties likeborderRadius
,backgroundColor
,borderColor
, andcolor
, ensuring a more consistent and semantic approach to styling. [1] [2] [3] [4] [5] [6] [7] [8] [9]Dependency and token updates:
@fluentui/semantic-tokens
as a dependency inpackage.json
to support the use of semantic tokens.foregroundCtrlIconOnNeutralRest
insemantic-tokens
and updated its fallback value to includecolorNeutralForeground3
. [1] [2] [3]Changelog:
@fluentui/react-input
package to document the minor update and its impact on dependent packages.