Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new package & theme, following Kumo theme pattern.
Visually inspected button components and updated border radii to match Copilot Theme (as defined by the FAI implementation)
Checkout semanticStyleHooks.ts for more notes.
Notes:
Overall thoughts:
Copilot's Theme only changes border radii and a few paddings to accommodate the different radii. However, it also creates new ones (though these new ones were only used in FAI components, not FUI components, which feels smelly to me)
borderRadius2XL: '12px',
borderRadius3XL: '16px',
borderRadius4XL: '24px',
borderRadius5XL: '40px',
There were some places where copilot theme took small, medium and large variants of components and unified their border radii to 8px. So changing the 3 radii token values to 8px just 'happened' to work in these instances (button and text area). However I do think there will be other components that will need to maintain the smaller or larger radii to 'work' (avatar, tag, tooltip, card) and we may have lost the fidelity to do so.
Said more simply, this token implementation inherently and strictly enforces relationships from the original design language which may not/should not exist in other design languages.