STREAMS API in Garnet #1131
Draft
STREAMS API in Garnet #1131
+4,484
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrishc
reviewed
Mar 24, 2025
PaulusParssinen
suggested changes
Mar 24, 2025
There was a problem hiding this comment.
First thanks for contributing!
I see the PR is marked as draft, but there's misunderstanding about the nature of Unsafe.AsPointer I want to help with as early as possible: It's use is always a mistake and unnecessary. Embrace Span<T> and normal struct usage as much as possible. I left few preliminary comments.
|
Two nits:
|
…icrosoft#1248) * Avoid memory allocation for hash operations wherever possible * Also reuse the existing value array for HSET * Changing ReadOnlySpan argument of WriteIntegerFromBytes scoped * Added an helper for key reading + avoid allocation for double increment --------- Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
…meout. (microsoft#1262) Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
* fix regression in script loading; previously, if repeatedly reloading the same script into a session would cause the cache to churn each time - substantially increasing allocations and runtime of SCRIPT|LOAD and EVAL * formatting * small style cleanups * min requirement of powershell 7, just for a nicer error message
* fix replication propagation in stored proc * add test for replication store proc * nit fix * enable ReadWriteSession for AofReplay * use txnVersion for enqueue in transactionManager * address comments
…d output after XADD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for STREAMS in Garnet.
Index Structure
Uses an in-memory B+tree (B-tree) index that has the following features:
Supported Operations in API
The following operations are currently supported:
STREAMID
Stream ID is a 128-bit ID for an entry in the Stream that is of a format
ts-seqwheretsis generally the timestamp andseqis the sequence number.STREAM
The Stream Object that consists of an instance to its
B-treeindex and aTsavoritelog instance for persistence. Every entry added to a Stream is first inserted into theTsavoritelog that returns the added address. This address is added as thevalueto the index using theSTREAMIDaskey.StreamManager
A container/wrapper that holds all Streams in the server in a dictionary.
SessionStreamCache
A local cache of Streams added by the client for faster access. Currently capped at
capacityand uses a simpleFIFOpolicy for the initial version. Can be extended to support other eviction strategies (preferablyLRU).