Standardize timeout parsing with correct errors for too small or too large #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See dotnet/runtime#116877 for the dotnet issue. |
TalZaccai
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of places where Garnet parses timeouts for blocking commands. These did not consistently error on negative values, and none of them errored on too large values (where .NET will raise an ArgumentOutOfRangeException and then Garnet closes the connection). Using a central SessionParseStateExtension for timeouts fixes all these issues neatly.
Note the .NET maximum timeout (int.MaxValue milliseconds) is far lower than the Valkey maximum timeout (63-bit integer seconds). I don't think the complexity justifies supporting this much? However, the .NET runtime maximum can be easily raised to uint32.MaxValue - 1 milliseconds, I'll be opening an issue on their tracker for this.