Skip to content

Fix LTTng Helper Macros for Enabled Events #3412

Open
@nibanks

Description

@nibanks

Describe the bug

#3411 effectively disables the following helper macros (and associated logging) in order to get a performance improvement:

#define QuicTraceLogStreamVerboseEnabled() FALSE
#define QuicTraceLogErrorEnabled()   FALSE
#define QuicTraceLogWarningEnabled() FALSE
#define QuicTraceLogInfoEnabled()    FALSE
#define QuicTraceLogVerboseEnabled() FALSE
#define QuicTraceEventEnabled(x) FALSE

We need to figure out how to correctly fix these instead of disabling them.

Affected OS

  • Windows
  • Linux
  • macOS
  • Other (specify below)

Additional OS information

No response

MsQuic version

main

Steps taken to reproduce bug

Use release builds of Linux libmsquic.

Expected behavior

All logging should work.

Actual outcome

Some don't because they're disabled.

Additional details

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Status

    Should be written

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions