Skip to content

Add Support for GetParam for Stat Sizes #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025
Merged

Add Support for GetParam for Stat Sizes #5111

merged 6 commits into from
May 23, 2025

Conversation

nibanks
Copy link
Collaborator

@nibanks nibanks commented May 20, 2025

Description

Add a new global parameter that returns the supported sizes of the QUIC_STATISTICS_V2 struct. Fixes #5110.

Testing

Updated. CI/CD

Documentation

Updated

@nibanks nibanks requested a review from a team as a code owner May 20, 2025 13:15
@microsoft microsoft deleted a comment from github-actions bot May 20, 2025
@microsoft microsoft deleted a comment from github-actions bot May 20, 2025
@microsoft microsoft deleted a comment from github-actions bot May 20, 2025
@microsoft microsoft deleted a comment from github-actions bot May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (0298f93) to head (22f64a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5111      +/-   ##
==========================================
- Coverage   87.10%   86.83%   -0.28%     
==========================================
  Files          59       59              
  Lines       18035    18048      +13     
==========================================
- Hits        15710    15672      -38     
- Misses       2325     2376      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mtfriesen
mtfriesen previously approved these changes May 22, 2025
guhetier
guhetier previously approved these changes May 23, 2025
Copy link
Contributor

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks but good to go otherwise.

@nibanks nibanks merged commit bb17196 into main May 23, 2025
339 of 344 checks passed
@nibanks nibanks deleted the stats-sizes-getparam branch May 23, 2025 15:49
nibanks added a commit that referenced this pull request May 23, 2025
nibanks added a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for a new Global Parameter to Query the Sizes of QUIC_STATISTICS_V2
3 participants