Skip to content

Receive buffer simplication [4/4] #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 30, 2025
Merged

Conversation

guhetier
Copy link
Contributor

@guhetier guhetier commented May 6, 2025

Description

  • Simplify the logic around the receive buffer growth logic
    • Remove code duplication and simplify control flow
  • Simplify logic around the pre-allocated chunk memory management
    • The receive buffer now own the chunk. The refactoring of pools makes it possible to deallocate it easily.

Testing

CI

Documentation

Already covered by existing documentation, comments updated.

@guhetier guhetier self-assigned this May 6, 2025
@guhetier guhetier added the Area: Core Related to the shared, core protocol logic label May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (2e4a9f0) to head (c68c32d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/recv_buffer.c 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5079      +/-   ##
==========================================
- Coverage   87.45%   86.94%   -0.51%     
==========================================
  Files          59       59              
  Lines       18048    18027      -21     
==========================================
- Hits        15783    15673     -110     
- Misses       2265     2354      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guhetier guhetier force-pushed the guhetier/recv_buffer_refactor_4 branch from 48a8969 to 00078ed Compare May 22, 2025 21:33
@guhetier guhetier marked this pull request as ready for review May 28, 2025 17:33
@guhetier guhetier requested a review from a team as a code owner May 28, 2025 17:33
@guhetier
Copy link
Contributor Author

One specific BVT seems to deadlock or crash on Windows kernel 2022 only. Need to investigate.

@guhetier guhetier force-pushed the guhetier/recv_buffer_refactor_4 branch from 00ffadf to c68c32d Compare May 29, 2025 16:05
@guhetier
Copy link
Contributor Author

Similar failure hits other PRs, this doesn't seem related to this change.

@guhetier guhetier merged commit 09f3c1b into main May 30, 2025
329 of 336 checks passed
@guhetier guhetier deleted the guhetier/recv_buffer_refactor_4 branch May 30, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants