Removed RegDeleteTreeA usage in storage_winuser #5182

gaurav2699 · 2025-06-24T12:02:59Z

Description

Gamecore builds are failing because it is not able to find the definition of RegDeleteTreeA in the undock pipelines.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

Is there any documentation impact for this change?

codecov · 2025-06-24T12:44:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.25%. Comparing base (fbcbaa2) to head (80e66b7).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5182      +/-   ##
==========================================
- Coverage   86.68%   86.25%   -0.44%     
==========================================
  Files          59       59              
  Lines       18233    18330      +97     
==========================================
+ Hits        15806    15811       +5     
- Misses       2427     2519      +92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nibanks · 2025-06-24T15:25:09Z

It seems like there is a missing include instead.

mtfriesen · 2025-06-24T15:31:39Z

It seems like there is a missing include instead.

I was wondering how this could be broken, but the documentation for RegDeleteTreeA says to include windows.h which we surely haven't missed?

anrossi · 2025-06-24T16:08:35Z

@nibanks I think gamecore specifically doesn't define the registry API, so we must define it here ourselves to build.

src/platform/storage_winuser.c

nibanks · 2025-06-24T16:37:34Z

I missed that this was gamecore specific. Generally, we just have to remove usage for things not on gamecore.

API is actually not in Gamecore

mtfriesen · 2025-06-24T17:53:59Z

I missed that this was gamecore specific. Generally, we just have to remove usage for things not on gamecore.

Yeah, now that I read the documentation for these partitions more carefully, if we declare functions ourselves, it's possible for Gamecore to successfully compile and maybe even link to APIs that will not be present on every Gamecore system, leading to runtime failures down the line.

guhetier · 2025-06-24T18:01:11Z

Oh, that would be bad and annoying.

Also, I just remembered that #5112 actually remove the use of RegDeleteTreeA and replace it with an iteration over the relevant keys. This PR might not be needed if we merge #5112.

gaurav2699 · 2025-06-26T11:53:00Z

Added the storage_winuser part from #5112 as discussed with Anthony to unblock gamecore builds as the PR still requires changes before it gets merged.

guhetier · 2025-06-26T15:46:46Z

You need to update the CLog manifest (scripts/update-sidecar.ps1)

src/platform/storage_winuser.c

mtfriesen · 2025-06-26T17:07:10Z

src/platform/storage_winuser.c

+
+            CXPLAT_FREE(ValueName, QUIC_POOL_PLATFORM_TMP_ALLOC);
+
+            AllocatedLength *= 2; // The API doesn't tell us the needed length; just double it.


Apparently the RegQueryInfoKeyA function returns lpcbMaxValueNameLen which is the answer.

Ah, so at the top call RegQueryInfoKeyA to get the initial value to use for AllocatedLength?

Yup, that's the theory.

+1 on using it then, it seems to me like a more natural pattern!

I have modified it according to the suggested method, please see if it looks fine. Thanks.

mtfriesen

LGTM as-is, though the RegQueryInfoKeyA approach may be tidier.

src/platform/storage_winuser.c

anrossi · 2025-06-27T23:37:08Z

Agree with Michael's comment, but this looks good too.

src/platform/storage_winuser.c

Co-authored-by: Nick Banks <nibanks@microsoft.com>

* added RegDeleteTreeA definition in restricted build * removed usage of RegDeleteTreeA * updated clog * max short * added comment * added RegQuertyInfKeyA * added line * Update src/platform/storage_winuser.c Co-authored-by: Nick Banks <nibanks@microsoft.com> --------- Co-authored-by: Nick Banks <nibanks@microsoft.com>

* Removed RegDeleteTreeA usage in storage_winuser (#5182) * added RegDeleteTreeA definition in restricted build * removed usage of RegDeleteTreeA * updated clog * max short * added comment * added RegQuertyInfKeyA * added line * Update src/platform/storage_winuser.c Co-authored-by: Nick Banks <nibanks@microsoft.com> --------- Co-authored-by: Nick Banks <nibanks@microsoft.com> * whitespace to trigger whitespace * remove whitespace to trigger CI --------- Co-authored-by: Nick Banks <nibanks@microsoft.com>

added RegDeleteTreeA definition in restricted build

ef78c74

gaurav2699 requested a review from a team as a code owner June 24, 2025 12:03

gaurav2699 requested a review from anrossi June 24, 2025 12:03

mtfriesen previously approved these changes Jun 24, 2025

View reviewed changes

guhetier reviewed Jun 24, 2025

View reviewed changes

src/platform/storage_winuser.c Outdated Show resolved Hide resolved

removed usage of RegDeleteTreeA

5f3013d

gaurav2699 changed the title ~~added RegDeleteTreeA definition in restricted build~~ Removed RegDeleteTreeA usage in storage_winuser Jun 26, 2025

guhetier mentioned this pull request Jun 26, 2025

Allow Configuration of Stateless Retry Key #5112

Merged

mtfriesen reviewed Jun 26, 2025

View reviewed changes

src/platform/storage_winuser.c Outdated Show resolved Hide resolved

mtfriesen reviewed Jun 26, 2025

View reviewed changes

src/platform/storage_winuser.c Show resolved Hide resolved

mtfriesen reviewed Jun 26, 2025

View reviewed changes

gaurav2699 added 3 commits June 27, 2025 00:56

updated clog

dfe8a1a

max short

4322d02

added comment

dc97266

mtfriesen previously approved these changes Jun 27, 2025

View reviewed changes

anrossi reviewed Jun 27, 2025

View reviewed changes

src/platform/storage_winuser.c Outdated Show resolved Hide resolved

anrossi previously approved these changes Jun 27, 2025

View reviewed changes

added RegQuertyInfKeyA

567acca

gaurav2699 dismissed anrossi’s stale review via 567acca June 30, 2025 10:36

gaurav2699 dismissed mtfriesen’s stale review via 567acca June 30, 2025 10:36

added line

a19d347

nibanks reviewed Jun 30, 2025

View reviewed changes

src/platform/storage_winuser.c Outdated Show resolved Hide resolved

nibanks previously approved these changes Jun 30, 2025

View reviewed changes

guhetier previously approved these changes Jun 30, 2025

View reviewed changes

Update src/platform/storage_winuser.c

80e66b7

Co-authored-by: Nick Banks <nibanks@microsoft.com>

gaurav2699 dismissed stale reviews from guhetier and nibanks via 80e66b7 June 30, 2025 19:22

gaurav2699 enabled auto-merge (squash) June 30, 2025 19:23

gaurav2699 requested a review from sachinrk July 1, 2025 08:40

sachinrk approved these changes Jul 1, 2025

View reviewed changes

gaurav2699 requested review from nibanks and guhetier July 1, 2025 15:31

guhetier approved these changes Jul 1, 2025

View reviewed changes

gaurav2699 merged commit 2623c07 into main Jul 1, 2025
438 of 439 checks passed

gaurav2699 deleted the gamecore_error branch July 1, 2025 15:51


		CXPLAT_FREE(ValueName, QUIC_POOL_PLATFORM_TMP_ALLOC);

		AllocatedLength *= 2; // The API doesn't tell us the needed length; just double it.

Removed RegDeleteTreeA usage in storage_winuser #5182

Removed RegDeleteTreeA usage in storage_winuser #5182

Uh oh!

Conversation

gaurav2699 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Documentation

Uh oh!

codecov bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nibanks commented Jun 24, 2025

Uh oh!

mtfriesen commented Jun 24, 2025

Uh oh!

anrossi commented Jun 24, 2025

Uh oh!

Uh oh!

nibanks commented Jun 24, 2025

Uh oh!

mtfriesen commented Jun 24, 2025

Uh oh!

guhetier commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaurav2699 commented Jun 26, 2025

Uh oh!

guhetier commented Jun 26, 2025

Uh oh!

Uh oh!

Uh oh!

mtfriesen Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anrossi Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

mtfriesen Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

guhetier Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

gaurav2699 Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

mtfriesen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anrossi commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaurav2699 commented Jun 24, 2025 •

edited

Loading

codecov bot commented Jun 24, 2025 •

edited

Loading

guhetier commented Jun 24, 2025 •

edited

Loading

mtfriesen Jun 26, 2025 •

edited

Loading