Skip to content

[Add] Tests for TLSLib, to cover: TLS connection and service creation, Cipher lists settings #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev/202405
Choose a base branch
from

Conversation

inbal2l
Copy link

@inbal2l inbal2l commented Mar 2, 2025

Description

Add tests for TLSLib, covers:

  • TLS Service/connection creation: TlsInitialize, TlsCtxNew, TlsNew, TlsCreateService, TlsCreateInstance, TlsSetConnectionEnd

  • TLS Ciphers settings: TlsSetCipherList, TlsGetCurrentCipher

  • Integrate to project TLSTests.c file

  • Modify .inf files in UnitTest\Library\BaseCryptLib to include the TLSTests.c file and lib.

  • Impacts functionality?

  • Impacts security?

  • Breaking change?

  • Includes tests?

  • Includes documentation?

  • Backport to release branch?

How This Was Tested

Compilation checked locally on dev machine. Tests runtime by running Tiano_platforms simulator.

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:security Has a security impact impact:testing Affects testing type:documentation Improvements or additions to documentation labels Mar 2, 2025
@inbal2l inbal2l changed the title [Add] TLS Tests Add tests for TLSLib, to cover: TLS connection and service creation, Cipher lists settings Mar 2, 2025
@inbal2l inbal2l changed the title Add tests for TLSLib, to cover: TLS connection and service creation, Cipher lists settings [Add] Tests for TLSLib, to cover: TLS connection and service creation, Cipher lists settings Mar 2, 2025
@makubacki makubacki requested a review from kenlautner May 22, 2025 22:19
inbal2l and others added 2 commits July 1, 2025 13:38
- Integrate to project TLSTests.c file
- Modify .inf files in UnitTest\Library\BaseCryptLib to include the
  TLSTests.c file and lib.
@Flickdm Flickdm force-pushed the tests/TLS_tests branch from 0c68b3f to 1f92670 Compare July 1, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:security Has a security impact impact:testing Affects testing type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants