vmm_tests: vmbus relay test for TDX #1472
Conversation
…eation was failing
mebersol
added
the
backport_2505
| ) | ||
|
|
||
| $vssd = Get-Vssd $Vm | ||
| $vssd | ForEach-Object { |
There was a problem hiding this comment.
Why do we need ForEach-Object here? For the other functions I was able to directly access the object members.
| @@ -197,3 +197,37 @@ function Set-VmScsiControllerTargetVtl | |||
| $rasd.TargetVtl = $TargetVtl | |||
| $rasd | Set-VmResourceSettings | |||
| } | |||
|
|
|||
| function Enable-VmBusRelay | |||
There was a problem hiding this comment.
nit: I think the standard capitalization is VMBus
| hyperv_openhcl_uefi_x64[vbs](vhd(windows_datacenter_core_2025_x64)), | ||
| hyperv_openhcl_uefi_x64[tdx](vhd(windows_datacenter_core_2025_x64)) | ||
| )] | ||
| async fn vmbus_relay(config: Box<dyn PetriVmConfig>) -> anyhow::Result<()> { |
There was a problem hiding this comment.
With this test, I think we can remove the x86_64::vmbus_redirect openvmm-only test.
| @@ -190,6 +190,10 @@ impl PetriVmConfig for PetriVmConfigOpenVmm { | |||
| fn with_uefi_frontpage(self: Box<Self>, enable: bool) -> Box<dyn PetriVmConfig> { | |||
| Box::new(Self::with_uefi_frontpage(*self, enable)) | |||
| } | |||
|
|
|||
| fn with_vmbus_relay(self: Box<Self>, _: bool) -> Box<dyn PetriVmConfig> { | |||
There was a problem hiding this comment.
nit: Should we switch everything to use vmbus redirect (rather than vmbus relay) terminology to be consistent?
| @@ -479,6 +485,9 @@ impl PetriVmConfigHyperV { | |||
| )?; | |||
| } | |||
|
|
|||
| // Enable/Disable VMBusRelay if requested in config | |||
| let _ = vm.set_vmbus_relay(self.vmbus_relay); | |||
There was a problem hiding this comment.
Why are we throwing away the result here? Shouldn't we just use ??
Also, this could probably be in the above if let Some(src_igvm_file) block since this would only be relevant for OpenHCL VMs right?
| Set-VmSystemSettings $vssd | ||
| } | ||
|
|
||
| function Disable-VmBusRelay |
There was a problem hiding this comment.
We could simplify this and the calling code by just accepting a boolean and calling the function Set-VMBusRedirect, but not a big deal.
Fix for issue #1268