-
Notifications
You must be signed in to change notification settings - Fork 132
flowey: output command for running vmm_tests #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vmm_tests/petri_artifact_resolver_openvmm_known_paths/src/lib.rs
Outdated
Show resolved
Hide resolved
I'm really excited to see
|
Thanks @mattkur for giving this a try.
|
nit, as I play with this further: |
I don't see the command written to a script. I do see the
In addition, can we do anything to more gracefully detect:
|
It only writes the command to a file if you pass |
For the test failures I was seeing: the ci pipeline sets the For the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed over teams, but we should make the --artifacts
flag require --filter
so that it's respected by the image dependency auto-installation. Should we update this document to reflect the changes in the dev workflow?
Improves the
xflowey vmm-tests
command to output thecargo-nextest
command need to run the tests outside of the flowey context, on Windows or Linux. This command is written to a script file in the output directory. Also build each package in a separate dir to avoid rebuilding.