virt_mshv_vtl: Wire up proper memory protections for the monitor page and enable it #1541
+97
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
commented
Jun 18, 2025
|
We were saying the MNF page is essentially an overlay page? I'm wondering if it needs special handling during modify_vtl_protection_mask calls or modifying the default protections. |
sluck-msft
reviewed
Jun 18, 2025
smalis-msft
force-pushed
the
monitor_prots
branch
from
cd35506 to
d2de4ec
Compare
smalis-msft
force-pushed
the
monitor_prots
branch
from
b22ce4e to
404b63c
Compare
smalis-msft
added
the
backport_2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is ugly, but we need to do per-backend things here despite being on the partition level, so it's necessary. We could maybe clean and split it up later somehow. Fixes #694