Tracing fixes backport to 2411 #1545
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter panic messages (printed to /dev/ttyprintk) out to a separate target and raise their effective trace level from verbose to critical. Fixes microsoft#439
…1462) tokio-rs/tracing#2519 can cause the tracing crate to mistakenly drop logs emitted after calling the `enabled!` macro. Today we only call that macro in two places; this PR removes one of them, the second is coming in another PR. We currently are using our dynamic tracing filtering to filter out what system-level messages get sent to the host, in addition to its normal purposes. After much investigation and thought I've come to the conclusion that there is no good way to work around this bug while maintaining dynamic configuration. So instead just statically code these levels. Realistically in terms of what these messages can help us diagnose this is almost certainly fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks of #1455 and #1462. #1469 is not needed on this branch.