Skip to content

Fix up AKCert index attributes #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 20, 2025
Merged

Fix up AKCert index attributes #1550

merged 7 commits into from
Jun 20, 2025

Conversation

stunes-ms
Copy link
Contributor

For now, the AKCert index needs to be owner-defined, not platform-defined. This change will fix up a mitigated vTPM appropriately.

@stunes-ms stunes-ms requested a review from a team as a code owner June 19, 2025 18:56
@stunes-ms
Copy link
Contributor Author

stunes-ms commented Jun 19, 2025 •
edited by mebersol
Loading

This is failing one of the TPM unit tests; still working on that. #Closed

@mebersol
Copy link
Collaborator

mebersol commented Jun 19, 2025 •
edited
Loading 

    // Test allocation after a restart with preserve_ak_cert = true, support_attestation_report = false

why is this failing?? #Closed

Refers to: vm/devices/tpm/src/tpm_helper.rs:2227 in b0742dc. [](commit_id = b0742dc, deletion_comment = False)

stunes-ms
stunes-ms commented Jun 19, 2025
View reviewed changes
mebersol
mebersol reviewed Jun 19, 2025
View reviewed changes
mebersol
mebersol reviewed Jun 19, 2025
View reviewed changes
@mebersol
Copy link
Collaborator

mebersol commented Jun 19, 2025 •
edited
Loading

can we add a new unit test specifically testing a plat-auth variable being removed and replace with an owner-auth variable? #Closed

@stunes-ms
Copy link
Contributor Author

stunes-ms commented Jun 20, 2025 •
edited by mebersol
Loading

can we add a new unit test specifically testing a plat-auth variable being removed and replace with an owner-auth variable?

Unit test added! #Resolved

mebersol
mebersol approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@mebersol mebersol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stunes-ms stunes-ms merged commit 20df503 into microsoft:main Jun 20, 2025
28 checks passed
@stunes-ms stunes-ms added backport_2411 Change should be backported to the release/2411 branch backport_2505 Change should be backported to the release/2505 branch labels Jun 20, 2025
stunes-ms added a commit to stunes-ms/openvmm that referenced this pull request Jun 20, 2025
@stunes-ms
Fix up AKCert index attributes (microsoft#1550)
11bde77 
For now, the AKCert index needs to be owner-defined, not
platform-defined. This change will fix up a mitigated vTPM
appropriately.
stunes-ms added a commit to stunes-ms/openvmm that referenced this pull request Jun 20, 2025
@stunes-ms
Fix up AKCert index attributes (microsoft#1550)
67f6cac 
For now, the AKCert index needs to be owner-defined, not
platform-defined. This change will fix up a mitigated vTPM
appropriately.
stunes-ms added a commit that referenced this pull request Jun 20, 2025
@stunes-ms
Fix up AKCert index attributes (#1550) (#1568)
629f1b3 
For now, the AKCert index needs to be owner-defined, not
platform-defined. This change will fix up a mitigated vTPM
appropriately.
stunes-ms added a commit that referenced this pull request Jun 20, 2025
@stunes-ms
Fix up AKCert index attributes (#1550) (#1569)
f99b4ac 
For now, the AKCert index needs to be owner-defined, not
platform-defined. This change will fix up a mitigated vTPM
appropriately.
stunes-ms added a commit to stunes-ms/openvmm that referenced this pull request Jun 23, 2025
@stunes-ms
Fix up AKCert index attributes (microsoft#1550)
ba50a40 
For now, the AKCert index needs to be owner-defined, not
platform-defined. This change will fix up a mitigated vTPM
appropriately.
@benhillis
Copy link
Member

Backported in #1569

@benhillis benhillis added backported_2505 PR that has been backported to release/2505 and removed backport_2505 Change should be backported to the release/2505 branch labels Jun 25, 2025
@benhillis
Copy link
Member

Backported in #1568

@benhillis benhillis added backported_2411 PR that has been backported to release/2411 and removed backport_2411 Change should be backported to the release/2411 branch labels Jun 25, 2025
@benhillis
Copy link
Member

Backported in #1568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mebersol mebersol

Assignees
No one assigned
Labels
backported_2411 PR that has been backported to release/2411 backported_2505 PR that has been backported to release/2505
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stunes-ms @mebersol @benhillis