Fix critical path traversal vulnerability in temp file creation #36362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated Changes by SimulateDev
Setup
Task
Fix critical path traversal security vulnerability in Playwright's temp file creation that could allow arbitrary file system write access.
Coding agents used
Summary
This PR addresses a critical security vulnerability in the Playwright codebase that allowed path traversal attacks through the
createTempFiles()
method. The vulnerability could have enabled attackers to write arbitrary files to the file system, potentially leading to remote code execution, data corruption, or privilege escalation. The fix implements proper path validation by sanitizing file names usingpath.basename()
and blocking directory traversal sequences. This security patch was developed using Windsurf with Claude Sonnet 4 as Planner and Cursor with Claude Sonnet 4 as Coder.What changed?
packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
createTempFiles()
method (lines 217-235)path.basename()
to prevent directory traversalReview Instructions
Please carefully review all changes before merging. While AI agents are powerful, human oversight is always recommended.
Generated by SimulateDev, the AI coding agents collaboration platform.