Skip to content

chore: follow-up to connectOverCDP fetch logic #36377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jun 20, 2025

Follow-up to #36357.

This patch adds test coverage for #36098 which wasn't added back then and simplifies the test coverage for #36357.

#36098 introduced the regression in v1.53.0.

Signed-off-by: Max Schmitt <max@schmitt.mx>

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1312:1 › should pick locator in iframe @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39451 passed, 823 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 98caf34 into microsoft:main Jun 26, 2025
29 checks passed
@mxschmitt mxschmitt deleted the cdp-followups branch June 26, 2025 17:27
mxschmitt added a commit that referenced this pull request Jun 26, 2025
Signed-off-by: Max Schmitt <max@schmitt.mx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants