-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix telemetry blank fields by correcting property mismatches and adding fallbacks #14763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ng fallbacks Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com>
@copilot run |
Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com>
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@copilot run |
@copilot fix this:
|
Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com>
Done! I've run Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com>
... I've fixed the change file issue. The problem was with the change file format/naming for the @react-native-windows/telemetry package. I've created a new properly formatted change file and committed it in 1accf2c. The pipeline should now pass the change file validation. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This PR fixes the issue where telemetry instances were displaying
<blank>
data in fields that should always be populated, such as CPU count, memory statistics, result codes, and command names.Root Cause
The telemetry system had two main issues:
Property name mismatches between setup and usage:
setupBaseProperties()
setsdeviceNumCPUs
anddeviceTotalMemory
trackEvent()
was incorrectly referencingnumCPUs
andtotalMemory
<blank>
fieldsMissing fallback values for edge cases where properties might be undefined
Changes Made
Fixed Property Name Mismatches
Added Fallback Values
Impact
<blank>
values for CPU count and memory in telemetry dashboardTesting
Fixes #14154.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io
/usr/local/bin/node install.mjs
(dns block)https://storage.googleapis.com/chrome-for-testing-public/130.0.6723.116/linux64/chrome-linux64.zip
/usr/local/bin/node install.mjs
(http block)If you need me to access, download, or install something from one of these locations, you can either: