fix CA2254: Template should be a static expression

[SimonCropp]

No description provided.

[DaveTryon]

I've read the page at https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2254, which explains the rule and how to apply it. It fails, however, to explain the reasoning behind the rule or what benefit it provides. I could imagine a benefit if we were planning to localize, but since that's not on any roadmap, CA2254 seems pointless here.

My objections are to the changes are twofold:

1. It requires more dev effort to mentally combine the formatting string and the parameters into what the output should look like. String interpolation makes this simple
2. It introduces a potential for the formatting string and the parameters to get out of sync. String interpolation avoids this problem.

I'd love to hear any concrete benefits CA2254 would bring to this project, then we can make a decision based on the merit of those benefits when weighed with the points I listed above.

[KalleOlaviNiemitalo]

I thought CA2254 only fires when methods of Microsoft.Extensions.Logging.LoggerExtensions are called with non-constant message templates. This code seems to be calling methods of Serilog.ILogger instead. How can it even get any CA2254 warnings?

[SimonCropp]

if you use interpolation, it means the logger cant tokenize the values.

so for example

logger.Information($"No namespace URI base provided, using unique generated default value {defaultNamespaceUriBase}");

the logger treats it as single string

but with

logger.Information("No namespace URI base provided, using unique generated default value {DefaultNamespaceUriBase}", defaultNamespaceUriBase);

the defaultNamespaceUriBase is extracted as a key value, so in the underlying logging infrastructure you can search and filers on the key defaultNamespaceUriBase or the value of that key

[SimonCropp]

here is an example tokenized log message in seq https://datalust.co/seq

u can see that the Handler property is tokenized out. if that log message had instead used interpolation, you would not have Handler as an extracted property

[SimonCropp]

should i resolve the conflicts?

[pragnya17]

should i resolve the conflicts?

Yes, please resolve the conflicts when you can