-
Notifications
You must be signed in to change notification settings - Fork 4k
.Net: Allow Kernel to be mutable by AgentChatCompletions #12538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rogerbarreto
merged 9 commits into
microsoft:main
from
rogerbarreto:issues/12534-fix-agent-kernel-mutability
Jun 25, 2025
Merged
.Net: Allow Kernel to be mutable by AgentChatCompletions #12538
rogerbarreto
merged 9 commits into
microsoft:main
from
rogerbarreto:issues/12534-fix-agent-kernel-mutability
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
approved these changes
Jun 19, 2025
dmytrostruk
approved these changes
Jun 20, 2025
shethaadit
approved these changes
Jun 20, 2025
@rogerbarreto is this integration test failure related to your changes?
|
westey-m
reviewed
Jun 23, 2025
@markwallace-microsoft This is unrelated error, I tried to run against my local configuration in Azure IT tests and passed as expected. |
westey-m
reviewed
Jun 23, 2025
westey-m
reviewed
Jun 23, 2025
Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
westey-m
approved these changes
Jun 23, 2025
westey-m
approved these changes
Jun 24, 2025
markwallace-microsoft
approved these changes
Jun 25, 2025
@microsoft-github-policy-service agree company="Microsoft" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes .Net: Bug: Kernel.Data no longer retains information across plugins since v1.54 #12534
This regression seems to be part of .Net: Add AIContextProvider support to Semantic Kernel #11689 where
kernel
instance was is cloned prior agent iterations, as I didn't captured any failing unit tests for the addedAIContext
providers considering this as a valid fix.Added UT covering the expected
Kernel
mutability.