Skip to content

.Net: Allow Kernel to be mutable by AgentChatCompletions #12538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rogerbarreto
Copy link
Member

Motivation and Context

@rogerbarreto rogerbarreto self-assigned this Jun 19, 2025
@rogerbarreto rogerbarreto requested a review from a team as a code owner June 19, 2025 12:42
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Jun 19, 2025
@rogerbarreto rogerbarreto added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2025
@rogerbarreto rogerbarreto enabled auto-merge June 20, 2025 21:58
@rogerbarreto rogerbarreto added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Jun 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2025
@markwallace-microsoft
Copy link
Member

@rogerbarreto is this integration test failure related to your changes?

[xUnit.net 00:05:48.23]     SemanticKernel.IntegrationTests.Connectors.AzureOpenAI.AzureOpenAIChatClientRequiredFunctionChoiceBehaviorTests.SpecifiedInPromptInstructsConnectorToInvokeKernelFunctionAutomaticallyAsync [FAIL]
[xUnit.net 00:05:48.23]       Polly.Timeout.TimeoutRejectedException : The operation didn't complete within the allowed timeout of '00:00:30'.
[xUnit.net 00:05:48.23]       ---- System.Threading.Tasks.TaskCanceledException : The operation was canceled.
[xUnit.net 00:05:48.23]       -------- System.IO.IOException : Unable to read data from the transport connection: Operation canceled.
[xUnit.net 00:05:48.23]       ------------ System.Net.Sockets.SocketException : Operation canceled

@rogerbarreto
Copy link
Member Author

@markwallace-microsoft This is unrelated error, I tried to run against my local configuration in Azure IT tests and passed as expected.

image

Co-authored-by: westey <164392973+westey-m@users.noreply.github.com>
@rogerbarreto rogerbarreto added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@rogerbarreto rogerbarreto added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Jun 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2025
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Jun 25, 2025
@rogerbarreto rogerbarreto enabled auto-merge June 25, 2025 10:38
@rogerbarreto
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

@rogerbarreto rogerbarreto added this pull request to the merge queue Jun 25, 2025
Merged via the queue into microsoft:main with commit cb74902 Jun 25, 2025
21 checks passed
@rogerbarreto rogerbarreto deleted the issues/12534-fix-agent-kernel-mutability branch June 25, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net: Bug: Kernel.Data no longer retains information across plugins since v1.54
5 participants