Switch to MIT license for NuGet packages #396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegsych
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Thanks for the PR @CodeBlanch. I think the license change should be fine, but the build error needs to be resolved.
Kielek
reviewed
Feb 25, 2025
|
@olegsych Updated |
rajkumar-rangaraj
approved these changes
Feb 25, 2025
Kielek
approved these changes
Feb 26, 2025
|
@olegsych, could you please re-review and possibly merge? |
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
olegsych
force-pushed
the
license-expression
branch
from
48d483f to
dbc0942
Compare
|
This is not the right place to change package licensing. It's used only to produce the intermediate/internal package we use in the publishing process. We'll circle back to licensing once the complete source code is on GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Details
There seems to be a disconnect between the license specified on NuGet packages and the actual license used by the code.
We are using these packages in OpenTelemetry and the recently introduced FOSSA scanning is reporting this as an issue.
/cc @Kielek @rajkumar-rangaraj