Skip to content

Assure cache lock release and reporting improvements #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gobradovic
Copy link
Contributor

@gobradovic gobradovic commented Apr 16, 2025

Release semaphore in finally block to ensure proper cleanup.

Add info level traces for start of the cleanup process and situations where we didn't acquire lock in time. Both situations should be fairly rare (not verbose).

@gobradovic gobradovic force-pushed the user/gobradovic/CommunicationClientCacheLockImprovement branch from 25b19e9 to 3994070 Compare April 16, 2025 14:06
@gobradovic gobradovic marked this pull request as ready for review April 16, 2025 14:27
@gobradovic gobradovic requested a review from olegsych April 22, 2025 16:26
@gobradovic gobradovic requested a review from olegsych May 23, 2025 13:22
@olegsych
Copy link
Member

Thanks @gobradovic. Everything looks good. Could you double-check the PR description and commit message for accuraty before you merge? I think it may not be entirely accurate anymore.

@gobradovic gobradovic changed the title Client cache lock and reporting improvements Assure cache lock release and reporting improvements May 23, 2025
@gobradovic gobradovic merged commit 7aaf1bd into develop May 23, 2025
5 checks passed
@gobradovic gobradovic deleted the user/gobradovic/CommunicationClientCacheLockImprovement branch May 23, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants