-
Notifications
You must be signed in to change notification settings - Fork 115
Build projects with net8 #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build projects with net8 #416
Conversation
AssemblyClsCompliant should be false since we dont use it and if removed default is false. AllowUnsafeBlocks is false by default so removing it.
...icrosoft.ServiceFabric.Actors.KVSToRCMigration/Extensions/KvsActorStateProviderExtensions.cs
Show resolved
Hide resolved
src/Microsoft.ServiceFabric.Actors.KVSToRCMigration/KVStoRCMigrationActorStateProvider.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ilijagrbic. I really like the direction of this PR. But let's keep it focused on netstandard2.0 -> net8.0 only and exclude the Linux changes for now. I'm concerned that even without Linux, we have a lot of significant changes, so let's slow down and think this through.
One particular reason for excluding Linux changes from this PR is that looking at the amount of complexity and confusion we're adding by repurposing the runtime-neutral TargetFramework net8.0 for a specific OS made me go back and think of other options. I think a simpler solution is to check if the process is running on Linux at runtime using OperatingSystem.IsLinux() or RuntimeInformation.IsOSPlatform(). That way we can continue building a single net8.0 binary.
Motivation
This PR introduces changes that are needed for multiple reasons.
Firstly, we will migrate away from netstandard2.0->net8.0 during the effort to support Mariner for SF. So, we are making similar migration here.
Other changes