Skip to content

Build projects with net8 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jul 16, 2025
Merged

Conversation

ilijagrbic
Copy link
Contributor

@ilijagrbic ilijagrbic commented May 29, 2025

Motivation

This PR introduces changes that are needed for multiple reasons.
Firstly, we will migrate away from netstandard2.0->net8.0 during the effort to support Mariner for SF. So, we are making similar migration here.

Other changes

  • Build all of the projects in this repo with net8.0 (instead of netstandard2.0)
  • Clean up property files
  • Other minor cleanup such as removing unnecessary properties, moving common properties to common files etc.

@ilijagrbic ilijagrbic marked this pull request as ready for review May 30, 2025 11:00
@ilijagrbic ilijagrbic requested a review from olegsych May 30, 2025 11:00
Copy link
Member

@olegsych olegsych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ilijagrbic. I really like the direction of this PR. But let's keep it focused on netstandard2.0 -> net8.0 only and exclude the Linux changes for now. I'm concerned that even without Linux, we have a lot of significant changes, so let's slow down and think this through.

One particular reason for excluding Linux changes from this PR is that looking at the amount of complexity and confusion we're adding by repurposing the runtime-neutral TargetFramework net8.0 for a specific OS made me go back and think of other options. I think a simpler solution is to check if the process is running on Linux at runtime using OperatingSystem.IsLinux() or RuntimeInformation.IsOSPlatform(). That way we can continue building a single net8.0 binary.

@ilijagrbic ilijagrbic requested a review from olegsych June 2, 2025 18:32
@olegsych olegsych merged commit 91819e1 into develop Jul 16, 2025
5 checks passed
@olegsych olegsych deleted the user/ilijagrbi/buildDiagnosticsWithNetCore branch July 16, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants