Skip to content

Remove Linux compiler directives from Microsoft.ServiceFabric.Diagnostics #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 10, 2025
Merged

Remove Linux compiler directives from Microsoft.ServiceFabric.Diagnostics #419

merged 22 commits into from
Jun 10, 2025

Conversation

ilijagrbic
Copy link
Contributor

@ilijagrbic ilijagrbic commented Jun 3, 2025 •
edited
Loading

1. Motivation/Goals

  • We are removing Linux specific compiler conditions from Diagnostics project (DotNetCoreClrLinux)
  • We will keep the same behavior but use Runtime-level checks to determine if Linux specific logic is needed
  • We are not addressing other issues with Diagnostics in this PR

2. Testing/Other

  • This PR adds some unit tests to test the changes - focusing on behavior around previous Linux specific compilation
  • This PR is being built with netstandard2.0 still, however in the future we can use newer API for platform checks.

@ilijagrbic ilijagrbic requested a review from olegsych June 4, 2025 10:52
@ilijagrbic ilijagrbic marked this pull request as ready for review June 4, 2025 10:52
@ilijagrbic ilijagrbic requested review from olegsych and removed request for olegsych June 6, 2025 10:14
olegsych
olegsych requested changes Jun 6, 2025
View reviewed changes
Copy link
Member

@olegsych olegsych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this @ilijagrbic. I have a few suggestions.

@ilijagrbic ilijagrbic requested a review from olegsych June 9, 2025 14:53
@ilijagrbic ilijagrbic merged commit c4fc3a1 into develop Jun 10, 2025
5 checks passed
@ilijagrbic ilijagrbic deleted the user/ilijagrbi/removeLinuxCompilerConditions branch June 10, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegsych olegsych

@gobradovic gobradovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilijagrbic @olegsych @gobradovic