Skip to content

Add a setting to manually set the Pane highlight color #3061

Open
@zadjii-msft

Description

@zadjii-msft
Member

Follow up from #994 and PR:#3060

In the aforementioned PR, we're just using the accent color for highlighting the pane. We should let that be a customizable global setting.

Questions:

  • There's been discussion before about allowing custom theming, hypothetically powered by XAML. Would we want to wait for that discussion to be had before we do this?
    • We'd probably want to change it from using SystemAccentColor to some FocusedPaneBorder color resource, that we define by default to be SystemAccentColor, should we decide to pursue this option
    • If we do want to do this in XAML later, would enabling it in the json now negatively impact that future scenario?

Activity

added
Area-UserInterfaceIssues pertaining to the user interface of the Console or Terminal
Area-SettingsIssues related to settings and customizability, for console or terminal
Issue-TaskIt's a feature request, but it doesn't really need a major design.
on Oct 4, 2019
ghost added
Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
on Oct 4, 2019
added this to the Terminal Backlog milestone on Oct 4, 2019
removed
Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
on Oct 23, 2019
javierdlg

javierdlg commented on Oct 29, 2019

@javierdlg
zadjii-msft

zadjii-msft commented on Oct 29, 2019

@zadjii-msft
Author

34 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-SettingsIssues related to settings and customizability, for console or terminalArea-ThemingAnything related to the theming of elements of the windowIn-PRThis issue has a related PRIssue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    Status

    Walkthrough in issue

    Relationships

    None yet

      Participants

      @SkyTrix@javierdlg@carlos-zamora@DHowett-MSFT@zadjii-msft

      Issue actions

        Add a setting to manually set the Pane highlight color · Issue #3061 · microsoft/terminal