Skip to content

If settings.json in portable settings folder (or folder itself) is not writeable WT will crash if you try to save settings #18913

New issue
New issue
Closed
Bug
#19027
Closed
If settings.json in portable settings folder (or folder itself) is not writeable WT will crash if you try to save settings#18913
Bug
#19027
Assignees
carlos-zamora
Labels
Area-SettingsIssues related to settings and customizability, for console or terminalIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsPriority-1A description (P1)Product-TerminalThe new Windows Terminal.Severity-CrashCrashes are real bad news.
Milestone
 
Terminal v1.24
@PGomersall

Description

@PGomersall
PGomersall
opened on May 14, 2025 · edited by PGomersall

Windows Terminal version

1.22.250314001 Portable (probably other versions as well)

Windows build number

10.0.26100.4061

Other Software

N\A

Steps to reproduce

Open settings UI, make a change click save > WT crashes

Expected Behavior

An error should be raised if settings.json is not writeable, but WT should not crash.

Actual Behavior

WT Crashes. If folder is writeable but not the settings.json file a settings.json.tmp is created

Activity

PGomersall
added
Issue-BugIt either shouldn't be doing this or needs an investigation.
Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
on May 14, 2025
PGomersall
added the
Bug
issue type on May 14, 2025
carlos-zamora
added
Area-SettingsIssues related to settings and customizability, for console or terminal
Severity-CrashCrashes are real bad news.
Product-TerminalThe new Windows Terminal.
Priority-1A description (P1)
on May 15, 2025
carlos-zamora
added this to the Terminal v1.24 milestone on May 15, 2025
carlos-zamora
self-assigned this
on May 15, 2025
Zeroes1

Zeroes1 commented on May 18, 2025

@Zeroes1
Zeroes1
on May 18, 2025

canary terminal-1.24.1351.0 same.

DHowett

DHowett commented on May 28, 2025

@DHowett
DHowett
on May 28, 2025
Member

Thanks! I could have sworn we had a duplicate for this, but it appears that we don't. Congrats!

Though: why is it not writable? 🙃

DHowett
added
Priority-3A description (P3)
and removed
Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
Priority-3A description (P3)
on May 28, 2025
PGomersall

PGomersall commented on May 28, 2025

@PGomersall
PGomersall
on May 28, 2025
Author

Though: why is it not writable?

@DHowett
I had a script to automate updating and or creation of the portable in C:\WT which runs as system. On some systems the default permissions on C:\ and therefore the inherited C:\WT did not give users more than read and execute. I added code in my script to deal with this, but wt should not crash regardless trying to write to the settings file that is effectively locked, hence my bug ticket.

12 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-SettingsIssues related to settings and customizability, for console or terminalIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsPriority-1A description (P1)Product-TerminalThe new Windows Terminal.Severity-CrashCrashes are real bad news.

Type

Projects

1.22 Servicing Pipeline

Status

Cherry Picked
1.23 Servicing Pipeline

Status

Cherry Picked

Milestone

Relationships

None yet

    Development

    Participants

    @DHowett@carlos-zamora@Zeroes1@PGomersall

    Issue actions
      If settings.json in portable settings folder (or folder itself) is not writeable WT will crash if you try to save settings · Issue #18913 · microsoft/terminal