Terminal icon picker is really behaving strange

[bpasero]

Steps to Reproduce:

1. go to terminals
2. select to change the icon

🐛 🐛 🐛

This widget seems nothing like anything we have in our UI normally (or is it maybe a hover?). It:

• is positioned wrongly, even though it has a beak
• its outline is cut off to the top making it look as if it goes outside of the window
• there is a "add" thing that I am not even sure what that is?

[Tyriar]

First 2 /duplicate #211083

"add" is the codicon id that will get highlighted when you filter.

[bpasero]

@Tyriar that really took a long time for me to understand, the UI is just really bad here because there is no visual separation between the icons and that text, it just hangs around. At the minimum I would have expected some kind of status line:

Besides, why do we need to show this when the user does not filter?

[Tyriar]

@bpasero this went through the ux sync for a few weeks already. I was the main one pushing for the id to show as I disliked emoji filters that didn't show you the text it was filtering behind the scenes.

@sandy081 owns the component if he wants to follow anything up. To me I'm not sure these components get the sort of engagement that make it worth this, the terminal one in particular is an extremely niche thing. Not sure about profiles editor engagement which is the main use case for the icon picker.

[bpasero]

@Tyriar the profile icon picker looks perfect to me and does not suffer from any of these issues:

It shows in context, and it does not show the identifier. This is exactly how I would think the terminal icon picker should work.

Reopening to try to align the two.

To me I'm not sure these components get the sort of engagement that make it worth this, the terminal one in particular is an extremely niche thing.

This is something I cannot really follow and imho can never be used as an argument for pushing UI that does not fit well into our system. If it is really not used that much, then I would rather remove the entire thing than having this experience today.