feature: edit previous requests #251732
Merged
feature: edit previous requests #251732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Jun 23, 2025
| @@ -167,6 +168,7 @@ export interface IChatResponseModel { | |||
| readonly isPendingConfirmation: IObservable<boolean>; | |||
| readonly isInProgress: IObservable<boolean>; | |||
| readonly shouldBeRemovedOnSend: IChatRequestDisablement | undefined; | |||
| shouldBeBlocked: boolean; | |||
There was a problem hiding this comment.
What does shouldBeBlocked mean exactly, that it's after the checkpoint? I don't really know what shouldBeRemovedOnSend is for, I wonder if it was meant for this case too?
| @@ -1333,20 +1574,30 @@ export class ChatWidget extends Disposable implements IChatWidget { | |||
|
|
|||
| this.input.validateAgentMode(); | |||
|
|
|||
| if (this.viewModel.model.checkpoint) { | |||
There was a problem hiding this comment.
Try to use VM objects outside of the model where possible, it's a bit cleaner
src/vs/workbench/contrib/chat/browser/actions/chatToolActions.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts
Outdated
Show resolved
Hide resolved
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
roblourens
approved these changes
Jun 24, 2025
auto-merge was automatically disabled
June 24, 2025 01:52
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/microsoft/vscode-copilot/issues/18304
re-adding all of https://github.com/microsoft/vscode/pull/230978/files