Skip to content

add session ID to terminal, send with suggest, quickfix, and creation events #252003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

meganrogge
Copy link
Contributor

Will enable us to look at completion outcomes for each shell type

@meganrogge meganrogge requested a review from Tyriar June 20, 2025 16:56
@meganrogge meganrogge self-assigned this Jun 20, 2025
@meganrogge meganrogge added this to the June 2025 milestone Jun 20, 2025
@meganrogge meganrogge enabled auto-merge (squash) June 20, 2025 16:56
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add here:

type QuickFixResultTelemetryEvent = {
quickFixId: string;
ranQuickFix: boolean;
};
type QuickFixClassification = {
owner: 'meganrogge';
quickFixId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The quick fix ID' };
ranQuickFix: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the quick fix was run' };
comment: 'Terminal quick fixes';
};
this._telemetryService?.publicLog2<QuickFixResultTelemetryEvent, QuickFixClassification>('terminal/quick-fix', {
quickFixId: id,
ranQuickFix: this._didRun
});

@meganrogge meganrogge requested a review from Tyriar June 20, 2025 17:08
@meganrogge meganrogge changed the title add session ID to terminal, send with suggest and creation events add session ID to terminal, send with suggest, quickfix, and creation events Jun 20, 2025
@meganrogge meganrogge merged commit 9dc4be3 into main Jun 20, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/session-id branch June 20, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants