Skip to content

Refactor upper right menu #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 129 commits into
base: main
Choose a base branch
from
Open

Refactor upper right menu #1209

wants to merge 129 commits into from

Conversation

dphanson63
Copy link
Collaborator

@dphanson63 dphanson63 commented Jun 8, 2025

Pull Request

Relevant Issue(s): #1232 and #1233

Description

Refactor upper right menu:

  • move prime directive to upper right menu
  • refactor user settings
  • refactor help options
  • address basic mobile view functionality
  • update dialog messaging

Bug or Feature?

  • Bug fix
  • New feature
  • Refactor

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 14.51613% with 53 lines in your changes missing coverage. Please review.

Project coverage is 50.00%. Comparing base (5350004) to head (6a15531).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/frontend/components/extensionSettingsMenu.tsx 9.61% 47 Missing ⚠️
src/frontend/components/feedbackBoardContainer.tsx 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   50.41%   50.00%   -0.42%     
==========================================
  Files          46       46              
  Lines        3360     3382      +22     
  Branches      898      908      +10     
==========================================
- Hits         1694     1691       -3     
- Misses       1666     1691      +25     
Files with missing lines Coverage Δ
.../frontend/components/feedbackBoardMetadataForm.tsx 48.50% <100.00%> (-0.63%) ⬇️
src/frontend/dal/boardDataService.tsx 96.25% <ø> (-0.05%) ⬇️
src/frontend/interfaces/feedback.tsx 33.33% <ø> (ø)
src/frontend/components/feedbackBoardContainer.tsx 22.45% <33.33%> (+0.19%) ⬆️
src/frontend/components/extensionSettingsMenu.tsx 13.63% <9.61%> (-1.67%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2025

Bundle Report

Changes will increase total bundle size by 872 bytes (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
retrospective-extension-webpack-bundle-array-push 1.68MB 872 bytes (0.05%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: retrospective-extension-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
./reflect-bundle.js 872 bytes 1.68MB 0.05%

Files in ./reflect-bundle.js:

  • ./components/feedbackBoardMetadataForm.tsx → Total Size: 45.58kB

  • ./components/feedbackBoardContainer.tsx → Total Size: 125.71kB

  • ./css/main.scss → Total Size: 1.21kB

  • ./components/extensionSettingsMenu.tsx → Total Size: 35.06kB

  • ./interfaces/feedback.tsx → Total Size: 1.86kB

  • ./dal/boardDataService.tsx → Total Size: 15.76kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants