[popover][dialog] Use click
event for outside press dismissal
#2275
+8
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2272
Some reasons why this is better:
Dialog.Trigger
andPopover.Trigger
both open onclick
, triggering the dismissal on mouseup instead of mousedown makes sense symmetrically and also ensures pressing outside to open a new dialog or popover dismisses the open one at the same time, which feels smootherNote: this doesn't apply if focus moves outside of the dialog or popover while pressing outside, which causes it to close on
mousedown
still (due to thefocusout
event). So if you click a Select trigger, which opens on mousedown, the Popover will also close on mousedown. This is expected anyway since you don't want to the Popover and Select to be open simultaneously during the delay between down and up pointer events.