Skip to content

Should we extend jenkins-alerts to release machines? #3414

@UlisesGascon

Description

@UlisesGascon
Member

I was thinking that currently we are only tracking the machines under ci.nodejs.org, but this is limited to the test machines. Should we extended it to the release machines?

Activity

richardlau

richardlau commented on Jul 7, 2023

@richardlau
Member

+1. FWIW our orka macOS release machines are currently all offline #3416

UlisesGascon

UlisesGascon commented on Jul 7, 2023

@UlisesGascon
MemberAuthor

I can create a PR for it, but I will need help to generate a valid token and also to add it in the repository secrets.

richardlau

richardlau commented on Jul 7, 2023

@richardlau
Member

I can create a PR for it, but I will need help to generate a valid token and also to add it in the repository secrets.

Hmm actually that's a good point. Do we remember which Jenkins user we're using? If it's one of the build automation GH users it won't have access to the release Cl.

changed the title [-]Should we extend jenkins-alerts to relese machines?[/-] [+]Should we extend jenkins-alerts to release machines?[/+] on Jul 7, 2023
UlisesGascon

UlisesGascon commented on Jul 7, 2023

@UlisesGascon
MemberAuthor

Hmm actually that's a good point. Do we remember which Jenkins user we're using? If it's one of the build automation GH users it won't have access to the release Cl.

Currently, I think it is using a personal token from my account on ci.nodejs.org, as it is the one that I used when building the project before it was transferred to Node.js.

self-assigned this
on Jul 7, 2023
richardlau

richardlau commented on Jul 7, 2023

@richardlau
Member

hmm. FWIW @UlisesGascon I sent an email to the other members of @nodejs/build-infra today suggesting we upgrade your level of access. Although maybe we ought to be setting up the automation with one of our Build WG-owned automation accounts.

UlisesGascon

UlisesGascon commented on Jul 7, 2023

@UlisesGascon
MemberAuthor

hmm. FWIW @UlisesGascon I sent an email to the other members of https://github.com/orgs/nodejs/teams/build-infra today suggesting we upgrade your level of access.

Thanks! :)

Although maybe we ought to be setting up the automation with one of our Build WG-owned automation accounts.

Yes, 100 we should replace the current token for a one generated by a Build WG-owned automation accounts and keep the token in the secrets repo as well.

I created a PR nodejs/jenkins-alerts#262 for the changes.

UlisesGascon

UlisesGascon commented on Jul 12, 2023

@UlisesGascon
MemberAuthor

@richardlau should I use @nodejs-ci account to generate the tokens?

richardlau

richardlau commented on Jul 12, 2023

@richardlau
Member

@UlisesGascon I can't remember if that account has access to Jenkins (either one). I think it's used by our Jenkins jobs to check code out of GitHub.

richardlau

richardlau commented on Jul 12, 2023

@richardlau
Member

@UlisesGascon @node-forward-build might be a better account to use, depending on whether we can create API tokens with less access than the user has.

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @UlisesGascon@richardlau

    Issue actions

      Should we extend jenkins-alerts to release machines? · Issue #3414 · nodejs/build