-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: redesigned home page with esp and updated downloads page #7875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
Lighthouse Results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7875 +/- ##
==========================================
- Coverage 75.46% 75.45% -0.02%
==========================================
Files 101 101
Lines 8306 8306
Branches 218 218
==========================================
- Hits 6268 6267 -1
- Misses 2036 2037 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
You might want a leading-tight (I think that's the right Tailwind class) on the support button as a whole, otherwise the xs line is still using the regular line height? And I'm still not sure about small text being bold :P Hover state for the support button in dark mode might need looking at now that it has the transparent bg? |
And then less of a design nit, but a general UX question, should this support button have an external link indicator? The links in the nav have it when they're external, so I could see it being a point of confusion that this then doesn't but is external? (It also doesn't open in a new tab like the nav external links) |
apps/site/pages/en/index.mdx
Outdated
|
||
<Button kind="primary" className="!block dark:!hidden w-100" href="/download">Install Node.js</Button> | ||
|
||
<Button kind="secondary" className="!hidden dark:!block w-100" href="https://www.herodevs.com/support/node-nes"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need UTM params I imagine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK what the campaign link should be 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeeames what UTM params would you like for the homepage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump, @joeeames
apps/site/pages/en/index.mdx
Outdated
<small className="text-xs!">for Node.js 18 and below</small> | ||
</Button> | ||
|
||
<Button kind="neutral" className="!block dark:!hidden w-100" href="https://www.herodevs.com/support/node-nes"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto, UTM params?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, this LGTM once we know what UTMs are needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR redesigns the home page and updates the download page (including the release modal) by simplifying CTAs and unifying messaging for EOL and LTS Node.js releases. Key changes include updates to UI component styles (e.g., BaseButton), modifications to localized error and alert messages, and adjustments in navigation logic for Node.js version selection.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/ui-components/Common/BaseButton/index.module.css | Updated styling for secondary buttons with added border properties and color adjustments. |
packages/i18n/locales/en.json | Revised warning text and added a notice for LTS version features. |
apps/site/pages/*/index.mdx (multiple locales) | Removed legacy home pages for various locales while updating the English version with a new button group. |
apps/site/layouts/layouts.module.css | Adjusted max-width and text color styles to support the new design. |
apps/site/layouts/GlowingBackdrop.tsx | Minor update: added a line break for clarity. |
apps/site/components/Downloads/ReleaseModal/index.tsx | Converted plain translations to rich translations to embed links in alert messages. |
apps/site/components/Downloads/Release/VersionDropdown.tsx | Updated version selection logic to redirect depending on the release status and route. |
apps/site/components/Downloads/Release/ReleaseCodeBox.tsx | Added an extra LTS alert box with a rich translation for better user guidance. |
Comments suppressed due to low confidence (1)
apps/site/components/Downloads/Release/VersionDropdown.tsx:38
- The variable 'release' declared here shadows the outer 'release' from context, which could lead to confusion. Consider renaming it to something like 'selectedRelease' to improve clarity.
);
|
||
<Button kind="primary" className="!block dark:!hidden" href="/download">Install Node.js</Button> | ||
|
||
<Button kind="secondary" className="!block" href="https://www.herodevs.com/support/node-nes"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Button kind="secondary" className="!block" href="https://www.herodevs.com/support/node-nes"> | |
<Button kind="secondary" className="!block" href="https://www.herodevs.com/support/node-nes?utm_source=NodeJS+&utm_medium=Link&utm_campaign=Homepage_button"> |
Unless we hear otherwise from @joeeames, let's roll with these UTMs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, then LGTM
@@ -168,7 +168,8 @@ | |||
"overview": "Overview", | |||
"minorVersions": "Minor versions", | |||
"releaseAnnouncement": "Release Announcement", | |||
"unsupportedVersionWarning": "This version is out of maintenance. Please use a currently supported version." | |||
"unsupportedVersionWarning": "This version is out of maintenance. Please use a currently supported version. <link>Understand EOL support.</link>", | |||
"ltsVersionFeaturesNotice": "Want new features sooner? Get the <link>latest Node.js version</link> instead and try the latest improvements on Node!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC "Node" shouldn't be used to describe the project.
"ltsVersionFeaturesNotice": "Want new features sooner? Get the <link>latest Node.js version</link> instead and try the latest improvements on Node!" | |
"ltsVersionFeaturesNotice": "Want new features sooner? Get the <link>latest Node.js version</link> instead and try the latest improvements!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a forbidden term (lint-wise) in core
This PR updates the Home Page with redesigned/simplified CTAs and updated the Download Page (and Release Modal) with unified EOL and LTS CTAs.
Closes #7773 (comment)