Skip to content

Download fails silently when logged out #3511

Open
@eyaler

Description

@eyaler

p5.js version

n/a

What is your operating system?

Windows

Web browser and version

firefox 139 / edge 136

Actual Behavior

nothing happens

Expected Behavior

if downloading is not allowed the option should be greyed out or better there should be a modal popup indicating what is the issue

Steps to reproduce

file->download a user's sketch when logged out

Activity

added
BugError or unexpected behaviors
on Jun 5, 2025
added
Good Medium IssueA moderately complex issue for contributors with some experience
Ready for WorkIssue is ready for development work
and removed on Jun 5, 2025
yugalkaushik

yugalkaushik commented on Jun 6, 2025

@yugalkaushik
Contributor

@raclim Can I work on this issue?

raclim

raclim commented on Jun 6, 2025

@raclim
Collaborator

@yugalkaushik yes please feel free to go ahead! :)

yugalkaushik

yugalkaushik commented on Jun 6, 2025

@yugalkaushik
Contributor

@eyaler @raclim I added a tooltip, since a popup can't be linked to the unauthenticated download button because nav buttons are disabled by default when the user isn't logged in.

raclim

raclim commented on Jun 10, 2025

@raclim
Collaborator

Thanks for the update @yugalkaushik!

As we discussed in the linked PR, if we want to use a tooltip, we may need to first come up with a way to implement one that's WCAG 2.2 compliant. I'm wondering since the Download button is already disabled when the user isn't logged in, maybe another potential solution could be updating the design to make it's disabled state a bit more evident?

yugalkaushik

yugalkaushik commented on Jun 10, 2025

@yugalkaushik
Contributor

Yes, that makes sense. We can update the design of the disabled button to make it more visually distinct something like a greyed-out button should help indicate it's inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugError or unexpected behaviorsGood Medium IssueA moderately complex issue for contributors with some experienceReady for WorkIssue is ready for development work

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @eyaler@raclim@yugalkaushik

    Issue actions

      Download fails silently when logged out · Issue #3511 · processing/p5.js-web-editor