You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There are a number of places like this where the code does an implicit fallthrough.
Could these please be marked with __attribute__((fallthrough)) (for C code) or [[fallthrough]] (for C++17 and above code)? That enables the use of -Wimplicit-fallthrough which requires that all fallthroughs be explicit, reducing potential error surfaces.
To Reproduce
To assist in reproducing the bug, please include the following:
Command/code being executed: N/A
Python version and OS: N/A
pip version: master
Output of pip list or conda list: N/A
Expected behavior
Fallthroughs are marked explicitly.
Additional context
Add any other context about the problem here.