gh-135557: Use atomic writes on heapq operations #135601
Open
+51
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuantengh
changed the title
|
I think this could be "skip news"? |
This is user-facing, so this does need a news. Something like "Fix race with lists and |
xuantengh
force-pushed
the
heap-list-lock-free-read
branch
from
f7fbb68 to
08770ec
Compare
Misc/NEWS.d/next/Library/2025-06-17-23-13-56.gh-issue-135557.Bfcy4v.rst
Outdated
Show resolved
Hide resolved
|
All commit authors signed the Contributor License Agreement. |
xuantengh
force-pushed
the
heap-list-lock-free-read
branch
from
0184b21 to
463963d
Compare
xuantengh
force-pushed
the
heap-list-lock-free-read
branch
from
463963d to
c49ff7d
Compare
| PyList_SET_ITEM(heap, 0, lastelt); | ||
| if (siftup_func((PyListObject *)heap, 0)) { | ||
| PyListObject *list = _PyList_CAST(heap); | ||
| FT_ATOMIC_STORE_PTR_RELAXED(list->ob_item[0], lastelt); |
There was a problem hiding this comment.
Similar change is needed in heappushpop and heapreplace
There was a problem hiding this comment.
It is needed in heappushpop_max and min as well
…fcy4v.rst Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
xuantengh
force-pushed
the
heap-list-lock-free-read
branch
from
c49ff7d to
27d6cb6
Compare
xuantengh
force-pushed
the
heap-list-lock-free-read
branch
from
2cc859d to
8cf4794
Compare
xuantengh
force-pushed
the
heap-list-lock-free-read
branch
from
8cf4794 to
32d767f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use atomic writes on heapq operation.