Skip to content

gh-135608: Add a null check for attribute promotion to fix a JIT crash #135613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 20, 2025
Merged

gh-135608: Add a null check for attribute promotion to fix a JIT crash #135613

merged 7 commits into from
Jun 20, 2025
+48 −2

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jun 17, 2025 •
edited by bedevere-app bot
Loading

@Fidget-Spinner Fidget-Spinner changed the title gh-135608: Add a null check for attribute promotion to fix a crash gh-135608: Add a null check for attribute promotion to fix a JIT crash Jun 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 17, 2025
Open
@Fidget-Spinner Fidget-Spinner requested a review from tomasr8 June 17, 2025 13:37
@Fidget-Spinner @devdanzin
Update test_opt.py
092ecc5 
Co-Authored-By: devdanzin <74280297+devdanzin@users.noreply.github.com>
@tomasr8
Copy link
Member

tomasr8 commented Jun 17, 2025

I'll take a look today or tomorrow :)

tomasr8
tomasr8 reviewed Jun 18, 2025
View reviewed changes
tomasr8
tomasr8 approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits/questions, otherwise LGTM! :)

@Fidget-Spinner
Copy link
Member Author

Thank you for the review. I have addressed the comments.

@Fidget-Spinner Fidget-Spinner merged commit b53b0c1 into python:main Jun 20, 2025
55 checks passed
@Fidget-Spinner Fidget-Spinner deleted the sym_new_const_bug branch June 20, 2025 06:33
@Fidget-Spinner Fidget-Spinner added the needs backport to 3.14 bugs and security fixes label Jun 20, 2025
@miss-islington-app
Copy link

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @Fidget-Spinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b53b0c14da58b73955b8989e4a9ce19ea67db7a3 3.14

Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request Jun 20, 2025
@Fidget-Spinner @devdanzin
pythongh-135608: Add a null check for attribute promotion to fix a JI…
06d625b 
…T crash (pythonGH-135613)

Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 20, 2025

GH-135739 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 20, 2025
Fidget-Spinner added a commit that referenced this pull request Jun 20, 2025
@Fidget-Spinner @devdanzin
[3.14] gh-135608: Add a null check for attribute promotion to fix a J…
60fc42c 
…IT crash (GH-135613) (#135739)

gh-135608: Add a null check for attribute promotion to fix a JIT crash (GH-135613)

Co-authored-by: devdanzin <74280297+devdanzin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@markshannon markshannon Awaiting requested review from markshannon

Assignees

@Fidget-Spinner Fidget-Spinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fidget-Spinner @tomasr8