-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135645: Added supports_isolated_interpreters
to sys.implementation
#135667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @vstinner! I would like to get a review from:
|
PEP 734 got an exception to be added to Python 3.14 after the feature freeze, no? |
When you're done making the requested changes, leave the comment: |
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 028b498 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135667%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 5fe139c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135667%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
This test fails on iOS: https://buildbot.python.org/#/builders/1382/builds/539 cpython/Lib/test/test_build_details.py Lines 76 to 84 in 9731dd2
@freakboy3742 can you please help me with understanding why? I don't know enough details about our |
Looks like that we generate |
@sobolevn It looks like this is a cross-compile issue. The build-details.json file is being seeded with the build python (macOS), but with So - the fix will be some sort of override to pass cross-platform details for That said - in this specific instance, I'm not clear why |
@sobolevn Also - flagging that although this isn't an issue for iOS, it will be an issue for Emscripten and WASI. There's no buildbot for Emscripten yet (hopefully that will land early next week), but the WASI buildbot appears to be flagging the same problem, for exactly the same reason. |
!buildbot wasi |
🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 9e3fa38 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135667%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
🤔 |
Ah - the entire build-details.json test suite is excluded (and it looks like build-details.json isn't generate for Emscripten at least.) I guess that's more of an indication that those builds haven't got PEP 739 support yet. |
📚 Documentation preview 📚: https://cpython-previews--135667.org.readthedocs.build/