Skip to content

Commit 366ef28

Browse files
dennisssSyntaxRules
authored andcommitted
fix(extension-registering) removeExtension implementation
1 parent 6ea6bbf commit 366ef28

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/converter.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -532,12 +532,12 @@ showdown.Converter = function (converterOptions) {
532532
var ext = extension[a];
533533
for (var i = 0; i < langExtensions.length; ++i) {
534534
if (langExtensions[i] === ext) {
535-
langExtensions[i].splice(i, 1);
535+
langExtensions.splice(i, 1);
536536
}
537537
}
538-
for (var ii = 0; ii < outputModifiers.length; ++i) {
538+
for (var ii = 0; ii < outputModifiers.length; ++ii) {
539539
if (outputModifiers[ii] === ext) {
540-
outputModifiers[ii].splice(i, 1);
540+
outputModifiers.splice(ii, 1);
541541
}
542542
}
543543
}

test/node/showdown.Converter.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,14 @@ describe('showdown.Converter', function () {
143143
converter.getAllExtensions().language.should.contain(extObjMock);
144144
showdown.resetExtensions();
145145
});
146+
147+
it('removeExtension() should remove an added extension', function () {
148+
var converter = new showdown.Converter();
149+
converter.addExtension(extObjMock);
150+
151+
converter.removeExtension(extObjMock);
152+
converter.getAllExtensions().language.should.not.contain(extObjMock);
153+
});
146154
});
147155

148156
describe('events', function () {

0 commit comments

Comments
 (0)