Skip to content

Adding new frame drum - duff #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sa-fw-an
Copy link
Member

Description

  • Updated the Drum list by adding a new type of frame drum called as duff. Users can now enjoy this new functionality :)

Users can access duff as shown in the video below:


Screen.Recording.2025-03-05.at.7.23.43.PM.mov

Copy link

✅ All Jest tests passed! This PR is ready to merge.

@sa-fw-an
Copy link
Member Author

sa-fw-an commented Apr 29, 2025

@pikurasa @walterbender Ive opened a new PR with updated Duff sample

Here is the sample:
Duff.zip

Please take a look at this :)

@walterbender
Copy link
Member

@pikurasa what does your ear say?

Copy link

This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the stale label is removed or commented on.

@github-actions github-actions bot added the Stale label Jun 28, 2025
@sa-fw-an
Copy link
Member Author

@pikurasa Could you please check this PR?

@walterbender
Copy link
Member

As soon as @pikurasa has time to test for sound quality, I am otherwise happy to merge.

@pikurasa
Copy link
Collaborator

I like the sample itself.

I just now tested it within MB, and the sample seems to be a bit quieter than the other drum samples. I would experiment with bringing the volume up between 150% and 200% of where it is right now. It's not a perfect science because all the drum sounds have different qualities, but we should try and get closer to something that's better balanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants