-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
remove: delete obsolete cache.appcache file #4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove: delete obsolete cache.appcache file #4664
Conversation
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender, could you kindly advise which documentation file would be most appropriate for adding a note about the removal of the deprecated file? |
Maybe the Readme in the lib dir? |
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender Please review. |
I thought you were going to add info about how/when to deprecate packages to the Readme. We don't need to add this specific explanation. It should be in the commit message. |
06fa60a
to
93907e8
Compare
✅ All Jest tests passed! This PR is ready to merge. |
@walterbender I misunderstood. I suggest a change. Please review. |
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
Fixes: #4665
Summary
This PR removes the deprecated
cache.appcache
file from the project. AppCache is an obsolete feature that is no longer supported in modern browsers due to security and performance concerns.The removal aligns with best practices outlined in the following resources:
Chrome Developer Lighthouse: AppCache Manifest
Meteor Documentation: AppCache Package
Chromium Blink Dev Discussion on AppCache Deprecation
We have already migrated to a Service Worker-based approach for offline functionality, as implemented in sw.js, making the AppCache file redundant.
Checklist
cache.appcache
from the codebase