Add missing tests for 'length' value of Intl.Locale.prototype methods #4515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
reviewed
Jun 4, 2025
| features: [Intl.DisplayNames] | ||
| ---*/ | ||
|
|
||
| verifyProperty(Intl.DisplayNames.prototype.of, "length", { |
There was a problem hiding this comment.
Can you instead update the other tests to use verifyPrimordialCallableProperty?
There was a problem hiding this comment.
verifyPrimordialCallableProperty doesn't support accessor methods, therefore I've instead used plain verifyProperty throughout this PR.
There was a problem hiding this comment.
verifyPrimordialCallablePropertydoesn't support accessor methods, therefore I've instead used plainverifyPropertythroughout this PR.
Yes it does, and I'm specifically planning for uses like test/intl402/Locale/prototype/baseName/descriptor.js:
var desc = Object.getOwnPropertyDescriptor(Intl.Locale.prototype, "baseName");
var isHardened = Object.isFrozen(Object);
if (isHardened && desc.get) {
Object.defineProperty(desc, "get", { configurable: false });
}
assert.sameValue(desc.value, undefined);
assert.sameValue(desc.set, undefined);
verifyCallableProperty(desc, "get", "get baseName", 0, { configurable: !isHardened });
verifyPrimordialProperty(Intl.Locale.prototype, "baseName", {
enumerable: false,
configurable: true,
});I'm also open to making even better accommodations, e.g.
var desc = Object.getOwnPropertyDescriptor(Intl.Locale.prototype, "baseName");
assert.sameValue(desc.value, undefined);
assert.sameValue(desc.set, undefined);
verifyPrimordialCallable(desc.get, "get baseName", 0);
verifyPrimordialProperty(Intl.Locale.prototype, "baseName", {
enumerable: false,
configurable: true,
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed this when reviewing the tests for
Intl.Locale.prototype.variants.