Skip to content

feat(vue-jsx): allow esbuild to perform ts transformation #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

madeofsun
Copy link

@madeofsun madeofsun commented Jul 4, 2025

Description

Additional context

In the original issue description the proposed new option tsTransform had values 'esbuild' and 'babel'. In the PR the 'esbuild' value was renamed to 'built-in' because it describes semantics more clearly and vite is planning to integrate rolldown as esbuild replacement.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-significant 🔨 High priority enhancement (priority) label Jul 7, 2025
Copy link

pkg-pr-new bot commented Jul 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@621
npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@621

commit: 0960987

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. Would you

  • resolve the conflicts?
  • fix the lint error?

By the way, do you have any performance numbers for each transform? I'm wondering if the plugin should use tsTransform: 'built-in' in the future as that would align to how plugin-react works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-significant 🔨 High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants