-
Notifications
You must be signed in to change notification settings - Fork 30
Issue 414: list constraints #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d on Node Shapes and add appropriate tests
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in the middle of implementing all this in Java and found various issues.
I have addressed the issues found - is there an(other?) open source implementation that'd be useful for me to implement the changes against (@bergos' JS shacl-engine perhaps) in case there are any more errors to catch. P.S. I am conferencing for the next 3 days so will be slow to respond |
Thanks for the fixes @HolgerKnublauch In case needed as future provenance for others: note that 58daff6 makes it such that if a list is malformed - the |
Closes #414. This PR implements
sh:minListLength
,sh:maxListLength
andsh:uniqList
.My interpretation of the following from the definition of 2.1.1 Constraints, Parameters and Constraint Components is that because the
sh:MemberShapeConstraintComponent
now has multiple parameters; there can only be one occurrence ofsh:memberShape
in a given shape - and I have updated thesh:maxCount
accordingly.This is currently targeted to #403 branch for a smaller diff in the GH UI. #403 should be merged and this targeted to
gh-pages
rather than merging this branch into #403