You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove __soc_is_irq from WCH, Bouffalolab, and Sensry Ganymed SoCs.
For WCH and Bouffalolab SoCs, CONFIG_RISCV_SOC_EXCEPTION_FROM_IRQ is
not enabled, so the function is never used. In both cases, the
implementation matches the default fallback (though the Bouffalolab
version is more complex).
For Sensry Ganymed (SY1xx), the config is enabled, but the function's
logic is identical to the default fallback, making it redundant.
I only tested with a WCH SoC (ch32v303), but for bouffalobab the code was dead and for ganymed SoCs the behaviour should be the exact same.
The __soc_is_irq function is only used when
CONFIG_RISCV_SOC_EXCEPTION_FROM_IRQ is enabled, which is not the case
for any WCH SoC. The implementation is therefore dead code.
Additionally, the implementation matches the default fallback behavior,
so no functional change would occur even if the config were enabled.
Signed-off-by: Miguel Gazquez <miguel.gazquez@bootlin.com>
The sy1xx SoC enabled CONFIG_RISCV_SOC_EXCEPTION_FROM_IRQ and provided
its own __soc_is_irq implementation. However, the behavior matches the
default implementation, making the override unnecessary.
This commit removes the custom implementation and disables the config
option to remove unnecessary code.
Signed-off-by: Miguel Gazquez <miguel.gazquez@bootlin.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
platform: sensry
platform: bouffalolab
platform: WinChipHead
labels
Remove __soc_is_irq from WCH, Bouffalolab, and Sensry Ganymed SoCs.
For WCH and Bouffalolab SoCs, CONFIG_RISCV_SOC_EXCEPTION_FROM_IRQ is
not enabled, so the function is never used. In both cases, the
implementation matches the default fallback (though the Bouffalolab
version is more complex).
For Sensry Ganymed (SY1xx), the config is enabled, but the function's
logic is identical to the default fallback, making it redundant.
I only tested with a WCH SoC (ch32v303), but for bouffalobab the code was dead and for ganymed SoCs the behaviour should be the exact same.