Bluetooth: Controller: Fix assertion using BT_CTLR_LOW_LAT_ULL_DONE #92715
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
carlescufi,
erbr-ot,
thoh-ot,
Tronil and
wopu-ot
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the placement of the done_inc() call under the CONFIG_BT_CTLR_LOW_LAT_ULL_DONE setting to prevent an assertion by moving it into the ULL_HIGH context.
- Removed early
done_inc()under low-latency macro and added it in the later conditional block - Inverted the
#if/#elsesodone_inc()is only called whenCONFIG_BT_CTLR_LOW_LAT_ULL_DONEis enabled
Comment on lines
548
to
550
| #else /* !CONFIG_BT_CTLR_LOW_LAT_ULL_DONE */ | ||
| done_inc(); | ||
| #endif /* !CONFIG_BT_CTLR_LOW_LAT_ULL_DONE */ |
There was a problem hiding this comment.
The comment on this #else branch is inverted: since this branch corresponds to CONFIG_BT_CTLR_LOW_LAT_ULL_DONE being defined, update the comment to /* CONFIG_BT_CTLR_LOW_LAT_ULL_DONE */.
Suggested change
| #else /* !CONFIG_BT_CTLR_LOW_LAT_ULL_DONE */ | |
| done_inc(); | |
| #endif /* !CONFIG_BT_CTLR_LOW_LAT_ULL_DONE */ | |
| #else /* CONFIG_BT_CTLR_LOW_LAT_ULL_DONE */ | |
| done_inc(); | |
| #endif /* CONFIG_BT_CTLR_LOW_LAT_ULL_DONE */ |
Copilot uses AI. Check for mistakes.
Thalley
previously approved these changes
Jul 7, 2025
BT_CTLR_LOW_LAT_ULL_DONE is used to reduce CPU usage in LLL context by delegating the done event dequeue to ULL_HIGH context. Building a HCI Controller with BT_CTLR_LOW_LAT_ULL_DONE had assertion when used with BlueZ stack. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_low_lat_ull_done_fix
branch
from
72a2be3 to
a60e59b
Compare
|
Addressed a minor copilot requested change. |
|
Thalley
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BT_CTLR_LOW_LAT_ULL_DONE is used to reduce CPU usage in LLL context by delegating the done event dequeue to ULL_HIGH context.
Building a HCI Controller with BT_CTLR_LOW_LAT_ULL_DONE had assertion when used with BlueZ stack.