Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add syntax highlighting for Emacs #5189

Merged
merged 3 commits into from
Mar 16, 2025

Conversation

vanillajonathan
Copy link
Collaborator

Adds a major mode for the GNU Emacs text editor which provides basic syntax highlighting.

It is basic. It doesn't use treesitter, nor does it provide code folding, formatting, REPL or anything.

@max-sixty
Copy link
Member

I thought that emacs supports tree-sitter now? Or not some versions / I'm mistaken?

@vanillajonathan
Copy link
Collaborator Author

Yes it does, modern versions of GNU Emacs (since version 29.1) now supports tree-sitter but the mode in this PR does not make use of the tree-sitter because I don't use Emacs and I don't know Emacs Lisp or Lisp so I wouldn't know how to do anything like that, hence I made just a very basic mode.

@max-sixty
Copy link
Member

OK, no strong objection to merging, but I'm guessing folks will just use the tree-sitter grammar rather than this... I had thought that if there's a tree-sitter grammar, then users can add it (but I also don't use emacs)

@vanillajonathan
Copy link
Collaborator Author

I don't know how users would add it, maybe they could contribute to this script to make it use tree-sitter and other features such as code formatter, code folding, indention and REPL.

@vanillajonathan vanillajonathan merged commit 2ced3d2 into PRQL:main Mar 16, 2025
33 of 34 checks passed
@vanillajonathan vanillajonathan deleted the emacs-syntax-highlighting branch March 16, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants