Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sterror not correctly piped #118

Open
IgnacioHeredia opened this issue Jul 26, 2023 · 0 comments
Open

sterror not correctly piped #118

IgnacioHeredia opened this issue Jul 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@IgnacioHeredia
Copy link
Collaborator

Description

Errors are not correctly piped. An error in the module code that prevents deepaas from launching is piped to stout, not sterr.

Steps to Reproduce

  1. Introduce error in module (raise Exception('some error'))
  2. Launch deepaas: deepaas-run

stout:

...
2023-07-26 14:05:38.595 149055 ERROR deepaas   File "/home/iheredia/ignacio/projects/deephdc/apps/demo_app/demo_app/api.py", line 103, in get_predict_args
2023-07-26 14:05:38.595 149055 ERROR deepaas     raise Exception('some error')
2023-07-26 14:05:38.595 149055 ERROR deepaas Exception: some error
2023-07-26 14:05:38.595 149055 ERROR deepaas 

sterr:

Two things might occur:

  • if Exception is raised in get_*_args, the deepaas process ends (with empty sterr)
  • if Exception was raised outside get_*_args, deepaas process does not end (an ERROR is just shown in stout).

In both cases, behaviour is incorrect.

Expected behavior:

Error message is in sterr.
deepaas should not launch if an error is raised outside get_*_args (though is coorectly ending if error is inside).

Actual behavior

Error message is in stout.
deepaas launching despite error.

Versions

2.0.0

@IgnacioHeredia IgnacioHeredia changed the title sterrornot correctly piped sterror not correctly piped Jul 26, 2023
@alvarolopez alvarolopez added the bug Something isn't working label Oct 2, 2023
@alvarolopez alvarolopez removed this from the 3.0.0 - Improve model loading milestone Dec 19, 2023
@alvarolopez alvarolopez removed their assignment Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants